Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lars cookbook #3248

Merged
merged 1 commit into from
Feb 27, 2017
Merged

lars cookbook #3248

merged 1 commit into from
Feb 27, 2017

Conversation

Saurabh7
Copy link
Contributor

@Saurabh7 Saurabh7 commented Jun 6, 2016

No description provided.

@karlnapf
Copy link
Member

karlnapf commented Jun 6, 2016

This needs integration testing data

Least Angle Regression
=======================

Least Angle Regression (LARS) is an algorithm used to fit a linear regression model. LARS is simliar to forward stagewise regression but less greedy. Instead of including variables at each step, the estimated parameters are increased in a direction equiangular to each one's correlations with the residual. LARS can be used to solve LASSO, which is basically L1-regularized least square regression.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "basically"

@Saurabh7
Copy link
Contributor Author

@karlnapf this looks ok ?

@karlnapf
Copy link
Member

Looks good to me.
What we need is

  • squash commits
  • send a data PR with integration testing data (before merging this one)
  • once that is merged, also update the data submodule hash in here so that integration tests are executed

@Saurabh7
Copy link
Contributor Author

Yes, I have linked the data pr. shogun-toolbox/shogun-data#122

@karlnapf
Copy link
Member

I just merged it, so only squash and data update

@karlnapf
Copy link
Member

Hey @Saurabh7 would you mind squashing these? Then we can merge

@Saurabh7
Copy link
Contributor Author

Yep, squashed and rebased.

@karlnapf karlnapf merged commit ec6860a into shogun-toolbox:develop Feb 27, 2017
@karlnapf
Copy link
Member

Another candidate for #3580

karasikov pushed a commit to karasikov/shogun that referenced this pull request Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants