Fixes #3253 Cookbook generation failure missing file indicator #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review and merge. |
|
I added this in f2b6e3b |
|
Let me know if you think this one is better, closing for now |
|
@karlnapf The crash happens earlier, when loading json. So it does not get to print the file name. |
|
As discussed in irc, a try - except would be better |
|
@karlnapf I updated this one. |
|
|
||
| translate_file = os.path.join(targetsDir, target) | ||
|
|
||
| with open(translate_file) as tFile: |
There was a problem hiding this comment.
is this both Python 2 and 3 compatible?
|
Good then, can you squash the commits into a single one? Then fine to merge |
…ible file indicator.
|
@karlnapf squashed in latest PR update. |
|
Thanks |
karasikov
pushed a commit
to karasikov/shogun
that referenced
this pull request
Apr 15, 2017
Fixes shogun-toolbox#3253 Cookbook generation failure missing file indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3253 Cookbook generation failure missing responsible file indicator.