add create() in class_list #3329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| TEST(class_list, create_gaussian_kernel) | ||
| { | ||
| const char* class_name = "GaussianKernel"; | ||
| auto gk = create<CGaussianKernel>(class_name); |
There was a problem hiding this comment.
create<CKernel>, this one is important for plugins switch
sanuj
force-pushed
the
class_list
branch
3 times, most recently
from
912ba2c
to
ada808e
Compare
|
|
||
| using namespace shogun; | ||
|
|
||
| %template(createKernel) create<CKernel>; |
There was a problem hiding this comment.
is this a prototype or why is this kernel only?
|
Closing this, will send a PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lisitsyn shall i add swig interface?