Updated interface for dependency translation rules. No more duplicate… #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elementTemplate = Template("$className") | ||
| if "DependencyListElementClass" in self.targetDict["Dependencies"]: | ||
| elementTemplate = Template(self.targetDict["Dependencies"]["DependencyListElementClass"]) | ||
| translations = set(map(self.translateDependencyElement, dependencies)) |
There was a problem hiding this comment.
@karlnapf Here I'm making sure that each translated dependency is unique. I.e. if two different dependencies (an enum and a class) result in the same import translation, then they're squashed.
| @@ -0,0 +1,239 @@ | |||
| /** Target files specify rules for translation from meta-language to a target | |||
There was a problem hiding this comment.
what type of file is this?
.js ?
There was a problem hiding this comment.
JavaScript. JSON does not support comments, so syntax highlighters make this hard to read. I could also change to markdown and wrap this in a code segment?
|
Great! |
karasikov
pushed a commit
to karasikov/shogun
that referenced
this pull request
Apr 15, 2017
Updated interface for dependency translation rules. No more duplicate…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… imports.
Also adds documentation for translation rules.