Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hessian to KernelExpFamily #3355

Conversation

sorig
Copy link
Member

@sorig sorig commented Jul 7, 2016

No description provided.


return result;
}

float64_t Base::log_pdf(SGVector<float64_t> x)
{
set_test_data(x);
return log_pdf(0);
return ((const Base*)this)->log_pdf(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the cast?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the ambiguity warnings. On my Mac it didn't compile because of this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok

On Thursday, 7 July 2016, Esben Sørig notifications@github.com wrote:

In src/shogun/distributions/kernel_exp_family/impl/Base.cpp
#3355 (comment):

return result;

}

float64_t Base::log_pdf(SGVector<float64_t> x)
{
set_test_data(x);

  • return log_pdf(0);
  • return ((const Base*)this)->log_pdf(0);

Fixes the ambiguity warnings. On my Mac it didn't compile because of this


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/shogun-toolbox/shogun/pull/3355/files/b45bdc86ebc800e8c2cfbf1a6268b91fee09bc9b#r69956349,
or mute the thread
https://github.com/notifications/unsubscribe/AAqqvy2iJLqpsG39Zb7mTNYY38nzZj44ks5qTUA0gaJpZM4JG80d
.

Sent from my phone

@karlnapf
Copy link
Member

karlnapf commented Jul 7, 2016

Looks good to me, merging!
Will try to do the nystrom one next week

@karlnapf karlnapf merged commit 462e026 into shogun-toolbox:feature/kernel_exp_family Jul 7, 2016
@sorig sorig deleted the feature/kernel_exp_family branch August 9, 2016 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants