echo solution for CMake error , for no meta example #3546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Nov 17, 2016
| @@ -4,7 +4,7 @@ GET_PYTHON_ENV() | |||
| # working directory of tester should be binary dir so link data folders | |||
| IF (NOT EXISTS ${CMAKE_CURRENT_BINARY_DIR}/reference_results) | |||
| IF (NOT EXISTS ${CMAKE_SOURCE_DIR}/data/testsuite/meta/) | |||
| MESSAGE(FATAL_ERROR "Test suite for meta examples does not exist!") | |||
| MESSAGE(FATAL_ERROR "Test suite for meta examples does not exist! please enter `git submodule update --init` to download. ") | |||
There was a problem hiding this comment.
Make this: "Please initialise and/or update the data submodule."
It is never a good idea to put explicit commands/names/etc into messages for users as these things outdate at lightning speed.
|
Nice, exactly this. Just a minor change and we are good (please suqash commits, or use git commit --amend on your branch) |
|
As I said above, please squash commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3535