LinalgRefactor - Enable matrix block elementwise product #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Feb 9, 2017
| * | ||
| * This version returns the result in-place. | ||
| * User should pass an appropriately allocate memory matrix | ||
| * Or pass one of the operands arguments (A or B) as a result |
There was a problem hiding this comment.
Watch your English here :) Punctuation, grammar etc.
Super minor!
|
Merge conflicts, otherwise good to go! |
OXPHOS
force-pushed
the
linalg_element_square
branch
from
be8d60b
to
10dfb8d
Compare
OXPHOS
force-pushed
the
linalg_element_square
branch
from
10dfb8d
to
4a45a46
Compare
|
@karlnapf ready |
|
Travis error unrelated, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to replace old
linalg::elementwise_square