Remove pthread header from SVMLightOneClass #3650
Conversation
There was a problem hiding this comment.
Need some comments by @vigsterkr and splitting into 3 PRs.
Unit tests should be there for single a multi-threaded versions
| @@ -33,10 +33,6 @@ extern "C" { | |||
|
|
|||
| #include <shogun/base/Parallel.h> | |||
|
|
|||
| #ifdef HAVE_PTHREAD | |||
| int32_t num_threads=1; | ||
| #endif | ||
| ASSERT(num_threads>0) | ||
| int32_t num_threads; |
There was a problem hiding this comment.
why do we need a variable for the number of threads?
| params[t].idx_comp=idx_b; | ||
|
|
||
| pthread_create(&threads[t], &attr, CDistanceMachine::run_distance_thread_lhs, (void*)¶ms[t]); | ||
| num_threads=omp_get_num_threads(); |
There was a problem hiding this comment.
@vigsterkr can you comment on the use of Parallel here?
There was a problem hiding this comment.
@karlnapf The variable involved need to be computed only once as they will remain constant over all the threads. In parallel the same computations will be repeated over all threads.
| SG_FREE(params); | ||
| SG_FREE(threads); | ||
| for(int32_t i=idx_r_start; idx_start < idx_stop; i++,idx_start++) | ||
| result[i] = distance->distance(idx_start,idx_b); |
There was a problem hiding this comment.
I wonder whether the distance matrix computation should be part of CDistance and then we just call that method from here?
src/shogun/machine/gp/Inference.cpp
Outdated
| @@ -39,18 +39,11 @@ | |||
| #include <shogun/mathematics/Math.h> | |||
| #include <shogun/lib/Lock.h> | |||
|
|
|||
| using namespace shogun; | |||
| #ifdef HAVE_OPENMP | |||
There was a problem hiding this comment.
can you please do every class in a separate PR?
abhinavrai44
force-pushed
the
feature/openmp
branch
2 times, most recently
from
072b764
to
3886356
Compare
abhinavrai44
changed the title
abhinavrai44
force-pushed
the
feature/openmp
branch
from
3886356
to
5c7f594
Compare
|
dunno what's happening with travis but i think this one is really safe to merge.... |
Remove pthread header from SVMLightOneClass
No description provided.