Avoid re-generating meta examples on make
#3659
Conversation
|
There are new errors in the scala build now. Repdoduce locally with See https://travis-ci.org/shogun-toolbox/shogun/jobs/205716515#L4975 |
|
Correct the Scala errors. The others Travis failures should be unrelated to my changes. |
| # FIXME | ||
| # Hack to avoid generation of scala meta examples dependencies that will | ||
| # not be generated by generate.py script (since there is no scala.json) | ||
| LIST(REMOVE_ITEM AVAILABLE_INTERFACES "ScalaModular") |
There was a problem hiding this comment.
peeeeeeeeeeeeople DISABLED_INTERFACES
There was a problem hiding this comment.
Adding the Scala module to DISABLED_INTERFACES will cause to not include examples/meta/scala/CMakeLists.txt. Only the Scala integration tests will be generated (and they will fail) and the flag -DScalaModular will become a bit useless (it will behave like an alias of -DJavaModular=ON).
This hack permits to create all the Scala tests anyway (generated and integration), but as I said before, this is just a workaround to prevent the continuous generation of the meta examples code.
|
Thanks! |
Avoid re-generating meta examples on `make`
Fix for issue #3653.
I believe this behaviour appeared after the introduction of the Scala interface. As I read from pull #3597, it was decided to run the java .class file with Scala (without generating the .scala files). However, the meta_examples target expects to find the all the .scala files, but since they are not present it triggers the re-generation of the meta examples.
IMHO this is a ugly workaround, but it solves the problem until a more advanced solution arrives.