Fix #3605, Port KernelMachine to OpenMP

[iRmantou]

No description provided.

[karlnapf]

A unit test for single a multi threads of a kernel machine would help

[iRmantou]

@karlnapf I see this PR has passed Travis. Travis CI can't check this , isn't it ? use ./bin/shogun-unit-test?

[karlnapf]

Yeah travis only checks single threaded.
Can you at least memcheck this locally using multiple threads?
If that is ok, we can merge

[iRmantou]

@karlnapf there is no unit test for KernelMachine in tests/unit/machine, isn't it? So I need to create it by myself ?

[iRmantou]

Can I use LibSVR_unittest which inherited from KernelMachine to test KernelMachine ?

[karlnapf]

Yes.
Just run it locally with single thread and multiple ones and make sure your patch didn't change the output/result

[iRmantou]

@karlnapf Is this right?

[karlnapf]

Almost, run this with a memory checker that checks thread safety

http://valgrind.org/docs/manual/hg-manual.html

Oh and please check whether the unit test uses the code you changed (i.e. runs in openmp parallel)

[iRmantou]

@karlnapf I cleaned the whole build directory and recompiled it with my code, so I am sure the unit test use the changed code, then I used valgrind , and there is no error message. The results are as follows

Is there anything I might have missed or need to note?

[karlnapf]

What I meant is:
Check the unit test code. Does it run things single AND multithreaded.
Also, tell valgrind to use the helgrind tool, see above readme

[iRmantou]

I have set export OMP_NUM_THREADS before I run the unit test.
What I should check or set in the unit test code like : LibSVR_unittest.cc to make sure it run things with multithreaded and single?

[karlnapf]

It doesnt really matter how you do it, the point is that you need to be aware what you are checking there. And that needs things to be explicitly executed single and multithreaded

[karlnapf]

Any updates here?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue is now being closed due to a lack of activity. Feel free to reopen it.