Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for different and unknown architectures #3801

Merged
merged 1 commit into from Apr 30, 2017
Merged

Better support for different and unknown architectures #3801

merged 1 commit into from Apr 30, 2017

Conversation

besser82
Copy link
Member

@besser82 besser82 commented Apr 30, 2017 •
edited

This fixes building on all arches; x86 / x86_64 are the only ones, which know about the opcode 'pause'.

@besser82 besser82 requested a review from vigsterkr April 30, 2017 00:48
@besser82 besser82 requested a review from lisitsyn April 30, 2017 08:57
@besser82 besser82 mentioned this pull request Apr 30, 2017
Merged
lisitsyn
lisitsyn approved these changes Apr 30, 2017
View reviewed changes
Copy link
Member

@lisitsyn lisitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It could make sense to put the fallback impl into a method called busy_loop to make it clear what it does.

@besser82
Copy link
Member Author

Well, that would bloat the code in this header a bit too much…

@besser82
Copy link
Member Author

As the inlined code already shows up as a function.

@besser82
Copy link
Member Author

Greaty! Will merge this in after TravisCI has passed. =)

@besser82
Copy link
Member Author

Everything should be fine now… Merging!

@besser82 besser82 merged commit ffb80ca into shogun-toolbox:develop Apr 30, 2017
@besser82 besser82 deleted the bugfix/cpu_h branch April 30, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisitsyn lisitsyn lisitsyn approved these changes

@vigsterkr vigsterkr Awaiting requested review from vigsterkr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@besser82 @lisitsyn