New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QDA #386
QDA #386
Conversation
|
||
} | ||
|
||
/* TODO avoid the repetition of the same operations here */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah you should really - precompute as much as is possible. then there is also no need to use the invsqrt approximation. so just store extra variables (or others processed).
your patch looks very nice to me - just fix the remaining TODOs and double check that it works (e.g. run it through valgrind / compare results with the scikits implementation) and it is fine to be merged! Thanks a lot! |
Here it is with the new changes we talked about. A quick summary:
Finally, the serialization of SGNDArray members is pending since you Please let me know about your opinion :) |
I messed a bit the previous pull request ( and my fork in general :S ) with commits that had nothing to do with QDA. I opened a new fork of shogun and have ordered the stuff properly.
Here it goes QDA. There are still a couple of comments in TODO dealing with a couple of doubts I have; they are just about things that probably could be done better but I was not really sure whether it pays off. I am waiting for your feedback :)