Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "new_sgserializable" to "create" #3905

Merged
merged 1 commit into from Jul 6, 2017

Conversation

lisitsyn
Copy link
Member

@lisitsyn lisitsyn commented Jul 5, 2017

No description provided.

@karlnapf
Copy link
Member

karlnapf commented Jul 5, 2017

Not sure "create" is the best name, but definitely better than the one before +1

@lisitsyn
Copy link
Member Author

lisitsyn commented Jul 5, 2017

I am open for suggestions ;)

@karlnapf
Copy link
Member

karlnapf commented Jul 5, 2017

Instantiate?

@codecov
Copy link

codecov bot commented Jul 5, 2017

Codecov Report

Merging #3905 into develop will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3905      +/-   ##
===========================================
- Coverage    53.29%   53.24%   -0.05%     
===========================================
  Files         1432     1432              
  Lines       104427   104427              
===========================================
- Hits         55653    55602      -51     
- Misses       48774    48825      +51
Impacted Files Coverage Δ
src/shogun/base/Parameter.cpp 55.33% <100%> (ø) ⬆️
src/shogun/base/SGObject.cpp 74.45% <100%> (+0.27%) ⬆️
src/gpl/shogun/lib/external/libqp_gsmo.cpp 19.73% <0%> (-65.79%) ⬇️
...g/kernelselection/internals/OptimizationSolver.cpp 87.71% <0%> (-5.27%) ⬇️
src/shogun/distance/BrayCurtisDistance.cpp 96.55% <0%> (-3.45%) ⬇️
src/shogun/machine/KernelMachine.cpp 78.91% <0%> (-0.32%) ⬇️
src/shogun/lib/external/shogun_libsvm.cpp 64.32% <0%> (+0.14%) ⬆️
src/shogun/distance/CosineDistance.cpp 100% <0%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce9137e...96b897a. Read the comment docs.

@lisitsyn lisitsyn merged commit 4063204 into shogun-toolbox:develop Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants