Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinalgRefactor - Drop legacy linalg codes #3936

Merged
merged 1 commit into from Jul 19, 2017

Conversation

OXPHOS
Copy link
Member

@OXPHOS OXPHOS commented Jul 18, 2017

No description provided.

@codecov
Copy link

codecov bot commented Jul 18, 2017

Codecov Report

Merging #3936 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3936      +/-   ##
===========================================
+ Coverage    54.08%    54.1%   +0.01%     
===========================================
  Files         1441     1441              
  Lines       105070   105070              
===========================================
+ Hits         56824    56845      +21     
+ Misses       48246    48225      -21
Impacted Files Coverage Δ
src/shogun/kernel/ExponentialARDKernel.cpp 84.72% <ø> (ø) ⬆️
src/shogun/multiclass/tree/CARTree.cpp 89.37% <ø> (ø) ⬆️
src/shogun/distance/BrayCurtisDistance.cpp 96.55% <0%> (-3.45%) ⬇️
src/shogun/distance/CosineDistance.cpp 97.14% <0%> (-2.86%) ⬇️
src/shogun/lib/external/shogun_libsvm.cpp 63.87% <0%> (-2.29%) ⬇️
src/shogun/optimization/liblinear/tron.cpp 86.61% <0%> (-0.71%) ⬇️
src/shogun/machine/KernelMachine.cpp 79.03% <0%> (ø) ⬆️
...g/kernelselection/internals/OptimizationSolver.cpp 92.98% <0%> (+8.77%) ⬆️
src/gpl/shogun/lib/external/libqp_gsmo.cpp 85.52% <0%> (+65.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587aacf...ced661e. Read the comment docs.

@OXPHOS OXPHOS merged commit 763a0de into shogun-toolbox:develop Jul 19, 2017
Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
We should also delete the old wiki page. Wanna do that?

@OXPHOS
Copy link
Member Author

OXPHOS commented Jul 20, 2017

Sure! I'll get the new version ready ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants