detect cblas.h during cmake for openblas #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigsterkr
requested changes
Dec 13, 2017
cmake/ShogunFindLAPACK.cmake
Outdated
| @@ -91,6 +91,22 @@ IF (LAPACK_FOUND) | |||
| ENDIF() | |||
| ENDIF() | |||
|
|
|||
| IF(FOUND_CBLAS_DGEMV AND NOT HAVE_ATLAS ) | |||
There was a problem hiding this comment.
remove the whitespace after HAVE_ATLAS
cmake/ShogunFindLAPACK.cmake
Outdated
| @@ -91,6 +91,22 @@ IF (LAPACK_FOUND) | |||
| ENDIF() | |||
| ENDIF() | |||
|
|
|||
| IF(FOUND_CBLAS_DGEMV AND NOT HAVE_ATLAS ) | |||
| #check is detected BLAS/LAPACK is OpenBLAS by looking for an OpenBLAS specific function | |||
| check_library_exists("${LAPACK_LIBRARIES}" openblas_set_num_threads "" FOUND_OPENBLAS) | |||
There was a problem hiding this comment.
to follow the logic _FOUND please change this to OpenBLAS_FOUND
cmake/ShogunFindLAPACK.cmake
Outdated
| #check if cblas.h exists | ||
| FIND_PATH(CBLAS_INCLUDE_DIR cblas.h) | ||
| IF(NOT CBLAS_INCLUDE_DIR) | ||
| MESSAGE(STATUS "Found OPENBLAS, but not cblas.h. Make sure that cblas headers are available in order to use OPENBLAS as BLAS/Lapack backend") |
There was a problem hiding this comment.
Make sure that cblas.h header is available within the header search path in order to use OpenBLAS as BLAS/Lapack backend
vigsterkr
approved these changes
Dec 14, 2017
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
detect cblas.h during cmake for openblas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3996
When Atlas is not detected, a further check is implemented to see if detected LAPACK API is OpenBLAS using search for an openBLAS specific function. If it is then cblas.h is checked otherwise all LAPACK flags are unset and error is shown.