Memory leaks fixes for unit tests #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisitsyn
approved these changes
Dec 20, 2017
| @@ -43,6 +43,7 @@ namespace shogun { | |||
| auto* cast = dynamic_cast<T*>(object); | |||
| if (!cast) | |||
| { | |||
| delete object; | |||
|
looks good! |
Codecov Report
@@ Coverage Diff @@
## develop #4036 +/- ##
===========================================
- Coverage 56.13% 56.13% -0.01%
===========================================
Files 1361 1361
Lines 94254 94259 +5
===========================================
+ Hits 52912 52914 +2
- Misses 41342 41345 +3
Continue to review full report at Codecov.
|
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
* [ProgressBar] Fix uninitialized variables. * [Valgrind] Fix memory leak inside create_object method. * [LDA] Fix memory leak inside LDA. * [KernelPCA] Fix memory leak inside unit test. * [FisherLDA] Fix memory leak inside unit test (unit-FLDATest). * [KRRNystrom] Fix memory leak inside unit test (unit-KRRNystrom). * [clang-format] Fix style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes some memory leaks discovered by valgrind inside unit tests.