Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store parameters in the AnyParameter wrapper #4052

Merged
merged 1 commit into from Dec 26, 2017
Merged

Store parameters in the AnyParameter wrapper #4052

merged 1 commit into from Dec 26, 2017

Conversation

lisitsyn
Copy link
Member

No description provided.

karlnapf
karlnapf approved these changes Dec 26, 2017
View reviewed changes
Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So your idea is to store specialisations of that AnyParameter in the map later on?

@lisitsyn
Copy link
Member Author

No I think it is where we store things like

  • Serialization ignored
  • Modelselection supported
  • ...

@karlnapf
Copy link
Member

Cool! Good to go from my side (travis timed out)

@lisitsyn lisitsyn merged commit 8715787 into shogun-toolbox:develop Dec 26, 2017
@lisitsyn lisitsyn deleted the any-parameter branch December 30, 2017 23:05
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
@lisitsyn @ktiefe
Store parameters in the AnyParameter wrapper (shogun-toolbox#4052)
ee3a911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlnapf karlnapf karlnapf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lisitsyn @karlnapf