New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename files for meta examples #4055
Rename files for meta examples #4055
Conversation
@dgkim5360 thanks for the PR and welcome! @karlnapf I think this one is for you |
Great stuff, thanks for the patch!!! |
I.e. each meta example generates output of the same filename as itself. |
See here https://travis-ci.org/shogun-toolbox/shogun/jobs/322523257#L4853 you can see that only the tests for the not-renamed files were executed. |
I see that's why the number of tests decreased when I renamed the files. I will check the READMEs and tests again, and also the |
After checking for renaming in the |
6451016
to
8aaac8e
Compare
I just recognized I have to update this PR for triggering CI (updating submodule version as you said), but I felt something wrong with the git working flow. Excuse me for taking some time to figure out for clean commits... |
I am not sure the job is done well. Please tell me if I need to adjust ! |
Looks good to me! Thanks a lot for the cleanup |
This was my first contribution for the open source project. Grateful for such opportunity and experience. |
Well done on that! :) |
* Rename files for meta examples * Update the data submodule version
Referring #4050