Support equals in operator== of Any #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisitsyn
force-pushed
the
smart-equals-in-any
branch
from
1c010d4
to
81f268f
Compare
vigsterkr
requested changes
Dec 28, 2017
| }; | ||
|
|
||
| template <class T> | ||
| auto compare_impl(by_default, T& lhs, T& rhs) = delete; |
There was a problem hiding this comment.
auto return is only c++14. but no worries just up the required version here:
https://github.com/shogun-toolbox/shogun/blob/develop/CMakeLists.txt#L35
lisitsyn
force-pushed
the
smart-equals-in-any
branch
from
81f268f
to
2b11cf5
Compare
|
@vigsterkr sir I did address your comments! |
vigsterkr
approved these changes
Dec 28, 2017
- REQUIRE C++14 FROM NOW ON
lisitsyn
force-pushed
the
smart-equals-in-any
branch
from
2b11cf5
to
3899f98
Compare
dgkim5360
pushed a commit
to dgkim5360/shogun
that referenced
this pull request
Jan 7, 2018
- REQUIRE C++14 FROM NOW ON
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
- REQUIRE C++14 FROM NOW ON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.