Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate methods for creating and updating parameters #4062

Merged
merged 1 commit into from Jan 1, 2018

Conversation

lisitsyn
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (develop@0bd36ee). Click here to learn what that means.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4062   +/-   ##
==========================================
  Coverage           ?   56.58%           
==========================================
  Files              ?     1332           
  Lines              ?    92831           
  Branches           ?        0           
==========================================
  Hits               ?    52531           
  Misses             ?    40300           
  Partials           ?        0
Impacted Files Coverage Δ
src/shogun/base/SGObject.h 100% <100%> (ø)
src/shogun/base/AnyParameter.h 92% <100%> (ø)
src/shogun/base/SGObject.cpp 71.46% <84.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd36ee...e6de8e9. Read the comment docs.

@lisitsyn lisitsyn merged commit 99e083f into shogun-toolbox:develop Jan 1, 2018
@lisitsyn lisitsyn deleted the update-parameter branch January 1, 2018 11:26
dgkim5360 pushed a commit to dgkim5360/shogun that referenced this pull request Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant