Do not link to python in conda (#4068) #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lisitsyn great that you've tracked down this one... only thing: dont' we wanna switch to static linking of the modular interfaces with libshogun eventually? would that actually fix this buck per se? |
vigsterkr
approved these changes
Jan 8, 2018
|
Yeah, I agree we want to link statically. But that's shogun linking. In this case it is python linking. |
|
Ok apparently I broke octave somehow :) |
lisitsyn
force-pushed
the
bugfix/anaconda-static
branch
from
961f610
to
842fd46
Compare
djsutherland
added a commit
to djsutherland/shogun-feedstock
that referenced
this pull request
Jan 10, 2018
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
…4073) * Do not link to python in conda (closes shogun-toolbox#4068) * Update FindOctave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.