Add linalg API to allow adding a vector to diagonal #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
changed the title
karlnapf
requested changes
Jan 18, 2018
| @@ -189,6 +190,35 @@ TEST(LinalgBackendEigen, SGMatrix_add_col_vec_in_place) | |||
| } | |||
| } | |||
|
|
|||
| TEST(LinalgBackendEigen, add_diag_vec) | |||
| { | |||
| const float64_t alpha = 0.7; | |||
There was a problem hiding this comment.
could you do this test more explicit, i.e. just write down the matrices by hand (no loops)
Otherwise good.
Also make sure to use EXPECT_THROW for the case of invalid input arugments (the REQUIRE)
Finally, test some corner cases (empty matrix doesnt give memory error, etc)
| * | ||
| * @see linalg::add_diag_vec | ||
| */ | ||
| #define BACKEND_GENERIC_ADD_DIAG_VEC(Type, Container) \ |
There was a problem hiding this comment.
I guess I would call this add_diag rather than add_diag_vec
A add_diag API to linalg to allow adding a vector to diagonal of a matrix.
vinx13
force-pushed
the
feature/linalg_add_diagonal
branch
from
4fc02bf
to
6693918
Compare
OXPHOS
reviewed
Jan 20, 2018
| EXPECT_THROW(add_diag(A1, b2), ShogunException); | ||
| EXPECT_THROW(add_diag(A2, b1), ShogunException); | ||
| EXPECT_THROW(add_diag(A2, b2), ShogunException); | ||
| } |
There was a problem hiding this comment.
IMHO, I'd shove all add_diag-related tests into one test unit for the neatness.
Otherwise good to me :)
|
Good work, thanks! |
karlnapf
pushed a commit
to karlnapf/shogun
that referenced
this pull request
Feb 4, 2018
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #4085 by @karlnapf , we need a API in linalg to allow adding a vector to a matrix's diagonal. This PR adds
add_diag_vecthat performs operationA.diagonal = alpha * A.diagonal + beta * b. Could you provide some feedback on the API design ?