Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newton SVM #409

Merged
merged 6 commits into from Apr 3, 2012
Merged

Newton SVM #409

merged 6 commits into from Apr 3, 2012

Conversation

harshitsyal
Copy link

I was having issues with removing conflicts in my previous pull request, So now I have created a new pull request in which everything is resolved,
I have rebased upstream/master in this, So i don't think there will be any more conflicts now.


/**
* set C
* @param C constant C
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indention

@sonney2k
Copy link
Member

sonney2k commented Apr 3, 2012

Harshit, looks like very nice work now! Please do the few final formatting fixes - mostly indention is still wrong / whitspace fixes and ifdefs need to be at beginning of lines and then this can be merged!

@harshitsyal
Copy link
Author

okay soeren, will commit new changes in a while,
Also do you want me to include the matlab example i prepared for testing on contypebianry_splice dataset?

And on contypebinary_splice dataset it takes around 6-14 sec to train on whole dataset, Time varies on amount of memory available i guess.

sonney2k pushed a commit that referenced this pull request Apr 3, 2012
@sonney2k sonney2k merged commit a934dcb into shogun-toolbox:master Apr 3, 2012
lisitsyn added a commit that referenced this pull request Apr 7, 2012
sonney2k pushed a commit that referenced this pull request May 22, 2012
lisitsyn added a commit that referenced this pull request May 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants