Implement array reference with any #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Jan 21, 2018
src/shogun/lib/any.h
Outdated
| { | ||
| return true; | ||
| } | ||
| return std::equal(*(m_ptr), *(m_ptr) + *(m_length), *(other.m_ptr)); |
There was a problem hiding this comment.
needs to be specialized for floats I guess?
There was a problem hiding this comment.
In fact need to check whether the elements support ".equals" or "->equals"
karlnapf
reviewed
Jan 21, 2018
| } | ||
| return std::equal( | ||
| *(m_ptr), *(m_ptr) + *(m_length), *(other.m_ptr), | ||
| [](T lhs, T rhs) -> bool { return any_detail::compare(lhs, rhs); }); |
vinx13
pushed a commit
to vinx13/shogun
that referenced
this pull request
Jan 28, 2018
karlnapf
pushed a commit
to karlnapf/shogun
that referenced
this pull request
Feb 4, 2018
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.