New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add clone_basic and clone_equals and serialization_ascii tests for all SGObjects #4125
Merged
karlnapf
merged 11 commits into
shogun-toolbox:develop
from
karlnapf:feature/test_all_sgobjects
Feb 4, 2018
Merged
add clone_basic and clone_equals and serialization_ascii tests for all SGObjects #4125
karlnapf
merged 11 commits into
shogun-toolbox:develop
from
karlnapf:feature/test_all_sgobjects
Feb 4, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
commented
Jan 26, 2018
tests/unit/base/SGObject_unittest.cc
Outdated
} | ||
} | ||
|
||
TYPED_TEST(SGObjectAll, clone_equals) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaces the old clone equals tests. Can obviously also be done for the serialization tests.
karlnapf
force-pushed
the
feature/test_all_sgobjects
branch
3 times, most recently
from
January 26, 2018 17:24
a5925e6
to
d35b26b
Compare
karlnapf
changed the title
add clone_basic and clone_equals tests for all SGObjects
add clone_basic and clone_equals and serialization_ascii tests for all SGObjects
Jan 26, 2018
karlnapf
force-pushed
the
feature/test_all_sgobjects
branch
14 times, most recently
from
February 2, 2018 16:55
7e74912
to
97853a4
Compare
karlnapf
force-pushed
the
feature/test_all_sgobjects
branch
from
February 3, 2018 11:35
4bfcefa
to
289ca74
Compare
karlnapf
force-pushed
the
feature/test_all_sgobjects
branch
from
February 3, 2018 23:14
fbafc70
to
8f3f36f
Compare
Jippiiie! |
karlnapf
added a commit
to karlnapf/shogun
that referenced
this pull request
Feb 4, 2018
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.