Created cookbook for passing vectors/matrix to features object #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use TARGETS instead of PROGRAMS so that it works on Windows as well
The 'git submodule update --init' command works only after changing directory to shogun before actually running the command
|
@yashdusing thxn for the PR, try to create your patch on top of |
|
Should I close this then ? |
|
@yashdusing you dont need to. just get your own branch |
|
Should I create another PR for a different branch or just leave it as it is for now? |
|
you should get your own branch in shape... no need for a new pr |
|
for further such question please consult google and search for github manuals |
|
As @vigsterkr said, pls dont close PRs and open new ones. Just update the old one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4105