Add cookbook and meta example for Canberra Distance #4138
Conversation
| Canberra Distance | ||
| ================== | ||
|
|
||
| The Canberra distance between vectors P and Q is the similarity as measured by their angle. |
There was a problem hiding this comment.
by their angle?
it's a weighted manhattan distance...
|
|
||
| .. sgexample:: canberra.sg:create_features | ||
|
|
||
| We create an instance of :sgclass:`CCanberraMetric` by passing it :sgclass:`CDenseFeatures`. |
There was a problem hiding this comment.
you mean something like:
We can create an instance of CanberraMetric by passing two Features objects for which features we would like to measure the pairwise Canberra distances.
syashakash
force-pushed
the
add-canberra
branch
from
0e5f9d0
to
6ced164
Compare
Rectify errata Link CDenseFeatures to its doc page everytime referenced Final edit
syashakash
force-pushed
the
add-canberra
branch
from
6ced164
to
4eab2e2
Compare
|
I wrote in #3000 |
|
|
||
| #![refresh_distance] | ||
| distance.init(features_a, features_b) | ||
| RealMatrix distance_matrix_ab = distance.get_distance_matrix() |
There was a problem hiding this comment.
could you send a PR to data with the integration testing data for this example? And then update this PR with that new data revision?
There was a problem hiding this comment.
Yes, I will.
First I would add a commit to this PR with removing the cookbook page and then add a commit for data revision.
|
Cool, the page is removed, but I don't see a PR for the data repo and you will also need to update the data submodule in this PR here |
|
The PR has merge conflicts, you will need to rebase against the latest develop |
|
wrong data submodule revision! Check the diff! |
syashakash
force-pushed
the
add-canberra
branch
from
2490abc
to
abc044c
Compare
|
Sorry for the late amend. I hope there are still no merge conflicts and the submodule is the one required. Travis still has one error with the jobs exceeding time limit that means there is some problem with the build, like this would require shortening the build, I guess! |
|
Tests passed, integration test included. Merging, and thanks! :) |
Issues #3000, #3555, #4047
All tests passed. No memory leaks found yet.