vector & matrix parameter descriptions in tags #4139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Feb 2, 2018
src/shogun/classifier/mkl/MKL.cpp
Outdated
| watch_param( | ||
| "beta_local", &beta_local, &beta_local_size, | ||
| AnyParameterProperties( | ||
| "subkernel weights on L1 term of elastic net mkl", MS_NOT_AVAILABLE, |
There was a problem hiding this comment.
same here, pls let's not have this MS_NOT_AVAILABLE, GRADIENT_NOT_AVAILABLE everytime, but instead hide it, and only write it out if things are available
|
@karlnapf Hi this is ready for review:) |
karlnapf
reviewed
Feb 12, 2018
| watch_param("beta_local", &beta_local, &beta_local_size); | ||
| watch_param( | ||
| "beta_local", &beta_local, &beta_local_size, | ||
| AnyParameterProperties( |
There was a problem hiding this comment.
Couldn't we have this without the AnyParameterProperties? but just string?
@lisitsyn
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue is now being closed due to a lack of activity. Feel free to reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes as suggested.
Comments: Some parameters in couple of classes doesn't have a description. Kept them as it is.