#3555 add meta_example for classifier_perceptron undocumented-sample #4140
Conversation
…mented-python-example
|
Welcome Paco, thanks for the patch! :) |
|
The example looks good. I have in the meantime merged you |
|
Done! :) Thank you! Now I'm gonna write a Cookbook page. |
|
Thanks for the contribution! :) |
|
btw is there still an undocumented python example that can be deleted? |
| @@ -0,0 +1,35 @@ | |||
| CSVFile f_feats_train("../../data/classifier_binary_2d_linear_features_train.dat") | |||
There was a problem hiding this comment.
ah, I had overseen this.
Can you pls send another PR where you move the perceptron to the "binary" folder, it does not really follow the NN structure in Shogun. Same for the data file.
Also could you remove the python example in the same PR?
There was a problem hiding this comment.
Ahh ok, I thought it had to be with NN examples, I'll move it and remove the python example...
Also... I'm seeing that one check didn't pass which is weird because I just send the data file... don't know :/
Well, I'lll do that and send another commit!
Hi! My name is Paco and I'm interested in this project and I would like to get involved with it.
I've created the sample and tested c and python result. They are both the same.
I'm sending another PR to shogun-data with the integration testing data output of the c++ executable and I'll make a cookbook page then.