Created cookbook for passing vectors/matrix to features object #4142
Conversation
|
|
||
| #![create_matrix] | ||
| RealMatrix real_matrix(2,3) | ||
| real_matrix[0,0]= Math:random(0, 5) |
There was a problem hiding this comment.
I think I would prefer if you put explicit values in here, 0,1,2,3,4,....
And then later in the notebook, you can extract feature vectors/matrices get_feature_vector(0) etc
| #![create_features] | ||
| RealFeatures features(real_vector) | ||
| #![create_features] | ||
|
|
There was a problem hiding this comment.
add some extraction illustration, i.e. how to get the vectors back from Shogun
| #![create_vector] | ||
| RealVector real_vector(5) | ||
| real_vector[0]= Math:random(0, 5) | ||
| real_vector[1]= Math:random(0, 5) |
| @@ -0,0 +1,33 @@ | |||
| ============================ | |||
There was a problem hiding this comment.
Filename should be just "features"
| @@ -0,0 +1,33 @@ | |||
| ============================ | |||
| Passing features from vector | |||
There was a problem hiding this comment.
Make this: "Passing data to Shogun"
| NOTE | ||
| ---- | ||
|
|
||
| It is important to note that conventionally, data is stored in a row-major fashion, meaning two row vector of size 3. |
There was a problem hiding this comment.
Suggestion: "Note that data is stored in column major format, i.e. each column of the matrix corresponds to an observation / feature vector, where each vector consists of a number of variables that is equal to the number of rows of the matrix."
I.e. add the wikipedia link for explanation and for the feature vector
| It is important to note that conventionally, data is stored in a row-major fashion, meaning two row vector of size 3. | ||
| However, in Shogun, this will be column vectors of dimension 2. This is beacuse each data sample is stored in a column-major fashion, | ||
| meaning each column here corresponds to an individual sample and each row in it to an atribute like BMI, Glucose concentration etc. | ||
| Also, it is essential to map the data types of the features object & vector i.e one cannot pass a vector of integers to a method that expects floats |
There was a problem hiding this comment.
This is a good point. Maybe it should be phrased "Note that features are type-safe, e.g. you can only pass 64 bit floating point numbers to RealFeatures.
| ---------- | ||
| References | ||
| ---------- | ||
| :wiki:`Feature (machine learning)` |
There was a problem hiding this comment.
good, also put the column major thing
| @@ -0,0 +1,16 @@ | |||
| Math:init_random(1) | |||
|
|
|||
There was a problem hiding this comment.
I in fact suggest to remove the vector example
|
Thank you for the feedback ! I will try to solve this as soon as possible. |
yashdusing
force-pushed
the
feature/vector_matrix_cookbook
branch
from
48381eb
to
d0b5200
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue is now being closed due to a lack of activity. Feel free to reopen it. |
Feature/vector matrix cookbook
Issue #4105