New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/fix perceptron issues #4146
Fix/fix perceptron issues #4146
Conversation
@@ -1,42 +0,0 @@ | |||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's name the file consistently with the others... just perceptron.sg
(and same for the data)
Cool! |
Perfect! I'm waiting this PR to be merger in Shogun-data before I could add the data folder to this PR. I do in this way because is said in developing.md but maybe I could have done all in this PR, I'm not familiar with git submodules. |
I think you can already change the submodule before it is merged....(not sure though) |
Okay, I think now everything is alright! Next time I'll do all faster haha |
Your data submodule is wrong in here: https://travis-ci.org/shogun-toolbox/shogun/jobs/337352894#L455 |
Pls check the travis builds yourself to see these errors in the future. |
Hi! sorry, I didn't see that it had failed! this time one of the travis test have failed with: "The job exceeded the maximum time limit for jobs, and has been terminated" having been working for 50 minutes while the rest of test pass in less than 20 minuts... I'll check again if there are more problems... |
Seems good now, thanks! |
Perceptron classifier should be in binary folder, not NN. Also I had to remove the old undocumented python example.