Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix perceptron issues #4146

Merged

Conversation

spothound
Copy link
Contributor

Perceptron classifier should be in binary folder, not NN. Also I had to remove the old undocumented python example.

@@ -1,42 +0,0 @@
#!/usr/bin/env python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's name the file consistently with the others... just perceptron.sg (and same for the data)

@karlnapf
Copy link
Member

karlnapf commented Feb 4, 2018

Cool!
Before this can be merged, the data file needs update, as does the submodule revision in this PR

@spothound
Copy link
Contributor Author

Perfect! I'm waiting this PR to be merger in Shogun-data before I could add the data folder to this PR.

I do in this way because is said in developing.md but maybe I could have done all in this PR, I'm not familiar with git submodules.

@karlnapf
Copy link
Member

karlnapf commented Feb 4, 2018

I think you can already change the submodule before it is merged....(not sure though)
It IS merged now however ;)

@spothound
Copy link
Contributor Author

Okay, I think now everything is alright! Next time I'll do all faster haha

@karlnapf karlnapf closed this Feb 4, 2018
@karlnapf karlnapf reopened this Feb 4, 2018
@karlnapf
Copy link
Member

karlnapf commented Feb 5, 2018

Your data submodule is wrong in here: https://travis-ci.org/shogun-toolbox/shogun/jobs/337352894#L455

@karlnapf
Copy link
Member

karlnapf commented Feb 5, 2018

Pls check the travis builds yourself to see these errors in the future.

@spothound
Copy link
Contributor Author

Hi! sorry, I didn't see that it had failed! this time one of the travis test have failed with: "The job exceeded the maximum time limit for jobs, and has been terminated" having been working for 50 minutes while the rest of test pass in less than 20 minuts...

I'll check again if there are more problems...

@karlnapf
Copy link
Member

karlnapf commented Feb 5, 2018

Seems good now, thanks!
You can see here that the integration test is executed as well (using your data) https://travis-ci.org/shogun-toolbox/shogun/jobs/337548666#L4824

@karlnapf karlnapf merged commit daa95fa into shogun-toolbox:develop Feb 5, 2018
@spothound spothound deleted the fix/Fix_perceptron_issues branch February 8, 2018 16:59
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants