Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old clone tests with systematic new one #4150

Merged
merged 4 commits into from Feb 5, 2018
Merged

Replace old clone tests with systematic new one #4150

merged 4 commits into from Feb 5, 2018

Conversation

karlnapf
Copy link
Member

@karlnapf karlnapf commented Feb 5, 2018

CSGObject::clone should be fully covered now i.e.

  • all parameter combinations that are used in Shogun are cloned in the test
  • after clone, object.equals(...) is true
  • non-empty objects to make meaningful test

@karlnapf
Copy link
Member Author

karlnapf commented Feb 5, 2018

no windows-specific changes here, merging

@karlnapf karlnapf merged commit acb321d into shogun-toolbox:develop Feb 5, 2018
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
@karlnapf @ktiefe
Replace old clone tests with systematic new one (shogun-toolbox#4150)
91b4a0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@karlnapf