cross validation classification meta example #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Feb 5, 2018
| @@ -0,0 +1,30 @@ | |||
| CSVFile f_feats("../../data/fm_train_real.dat") | |||
There was a problem hiding this comment.
just call it: cross_validation_support_vector_machine.sg
karlnapf
reviewed
Feb 5, 2018
| #![create_cross_validation] | ||
|
|
||
| #![evaluate_and_get_result] | ||
| CrossValidationResult result() |
karlnapf
reviewed
Feb 5, 2018
| StratifiedCrossValidationSplitting splitting_strategy(labels, 5) | ||
| AccuracyMeasure evaluation_criterium() | ||
| CrossValidation cross(svm, features, labels, splitting_strategy, evaluation_criterium) | ||
| cross.set_autolock(False) |
There was a problem hiding this comment.
no need as this is not a kernel machine? Or does it produce warnings?
karlnapf
reviewed
Feb 5, 2018
|
|
||
| #![create_cross_validation] | ||
| StratifiedCrossValidationSplitting splitting_strategy(labels, 5) | ||
| AccuracyMeasure evaluation_criterium() |
karlnapf
reviewed
Feb 5, 2018
| svm.set_liblinear_solver_type(enum LIBLINEAR_SOLVER_TYPE.L2R_L2LOSS_SVC) | ||
| #![create_classifier] | ||
|
|
||
| #![create_cross_validation] |
There was a problem hiding this comment.
the comments are only necessary if you write a cookbook page (you can leave them for now though)
karlnapf
requested changes
Feb 5, 2018
shubham808
force-pushed
the
feature/cross_validation_classification_meta_example
branch
from
4c66531
to
9eadcd2
Compare
|
@karlnapf does this look okay? |
|
It does :) |
karlnapf
approved these changes
Feb 6, 2018
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3000 making meta for undocumented cross validation classification example. if this is okay how about we write a cookbook page?