Meta examples: add functionality for special translations of certain method calls #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorig
commented
Feb 19, 2018
| "MethodCall": { | ||
| "Default": "$object->$method($arguments)", | ||
| "get_real": "$object->get<float64_t>($arguments)" | ||
| }, | ||
| "StaticCall": "C$typeName::$method($arguments)", | ||
| "GlobalCall": "$method($arguments)", |
There was a problem hiding this comment.
Do you think you would need something similar for StaticCall and GlobalCall? Can easily implement but haven't done it for now
There was a problem hiding this comment.
I think this should suffice for now
sorig
force-pushed
the
meta_lang_typed_getters
branch
from
3adf955
to
bdf66e8
Compare
karlnapf
reviewed
Feb 20, 2018
| @@ -0,0 +1,2 @@ | |||
| Kernel k = kernel("GaussianKernel") | |||
There was a problem hiding this comment.
could you remove this file? it makes the build fail as the method is not implemented.
I will use things in the feature branch
|
Thanks for the quick response :) |
sorig
force-pushed
the
meta_lang_typed_getters
branch
from
bdf66e8
to
adf0f22
Compare
sorig
force-pushed
the
meta_lang_typed_getters
branch
from
adf0f22
to
6f108a0
Compare
|
Travis is happy now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows typed getters like
get_realto be translated toget<float64_t>in C++ andget_realin the SWIG interfaces.Note that typed setters (
put) would be more tricky as we'd have to type the keyword arguments