Add transpose flags to element_prod #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Feb 20, 2018
| result_eig = a_block.array() * b_block.array(); | ||
| if (transpose_A && transpose_B) | ||
| result_eig = a_block.transpose().array() * b_block.transpose().array(); | ||
| else if (transpose_A) |
There was a problem hiding this comment.
why the copy paste? why doesnt one method call the other?
karlnapf
reviewed
Feb 28, 2018
| if (transpose_A && transpose_B) | ||
| result_gpu->data_matrix(result.num_rows, result.num_cols) = | ||
| viennacl::linalg::element_prod( | ||
| viennacl::trans( |
There was a problem hiding this comment.
cant we store the "trans" in a varialbe and then use that in the if-then-else. Then we don't copy the whole code block 3 times ...
|
Thanks! |
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
* Add transpose flags to element_prod * Extract common part of element_prod as helper method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add transpose flags to arguments of
linalg::element_prodThis makes
element_prodhave a consistent interface asmatrix_prod