Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop CMath log #4189

Merged
merged 1 commit into from Feb 28, 2018
Merged

drop CMath log #4189

merged 1 commit into from Feb 28, 2018

Conversation

shubham808
Copy link
Contributor

@shubham808 shubham808 commented Feb 28, 2018 •
edited

#4186 replacing CMath::log with std::log at a few places

@karlnapf
Copy link
Member

LGTM ..... why not drop the CMath::log altogether in the PR?

@shubham808
Copy link
Contributor Author

yup its my next commit :)

@karlnapf
Copy link
Member

Cool thx!

@karlnapf karlnapf merged commit eb794d6 into shogun-toolbox:develop Feb 28, 2018
@shubham808 shubham808 deleted the feature/remove_CMath_log branch March 2, 2018 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shubham808 @karlnapf