Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cmath::sqrt with std::sqrt #4218

Merged
merged 4 commits into from Apr 2, 2018
Merged

Replace cmath::sqrt with std::sqrt #4218

merged 4 commits into from Apr 2, 2018

Conversation

grig-guz
Copy link
Contributor

@grig-guz grig-guz commented Mar 26, 2018

Fixed the previous pull request

@grig-guz grig-guz closed this Mar 26, 2018
@grig-guz grig-guz reopened this Mar 26, 2018
@vigsterkr
Copy link
Member

looks better... let's see what the CI says

@vigsterkr
Copy link
Member

@grig-guz great! there are still some formatting errors. you can fix those by using clang-format; for details check the 8th point in https://github.com/shogun-toolbox/shogun/blob/develop/doc/readme/DEVELOPING.md

@grig-guz
Copy link
Contributor Author

@vigsterkr thanks! However, I'm not sure how to fix some of these errors. I ran the clang-format-3.8 as recommended by the script, but I still get errors like these
error

@vigsterkr
Copy link
Member

@grig-guz i'm not so sure what you mean by the cropped image but this is clearly a formatting problem:
https://travis-ci.org/shogun-toolbox/shogun/jobs/359204608#L760

or

result=1.0-CStatistics::normal_cdf(statistic, std_dev);

should be
result = 1.0 - CStatistics::normal_cdf(statistic, std_dev);

@grig-guz
Copy link
Contributor Author

grig-guz commented Mar 29, 2018

The style check passed. Is it fine now?
The problem was that the automatic reformatting tool was not fixing all errors. It was not doing anything in case when line padding was wrong (say, 8 spaces instead of 2 tabs), but the formatting error detection script was treating it as an error.

@grig-guz
Copy link
Contributor Author

Also, the formatting error detection script was inconsistent in some places. Sometimes, it required for line padding to only consist of tabs, and in other classes it was asking for tabs and 2-3 spaces.

@karlnapf
Copy link
Member

karlnapf commented Apr 2, 2018

Thx for the patch!

@karlnapf karlnapf merged commit c8fee5d into shogun-toolbox:develop Apr 2, 2018
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants