New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cmath::sqrt with std::sqrt #4218
Replace cmath::sqrt with std::sqrt #4218
Conversation
looks better... let's see what the CI says |
@grig-guz great! there are still some formatting errors. you can fix those by using clang-format; for details check the 8th point in https://github.com/shogun-toolbox/shogun/blob/develop/doc/readme/DEVELOPING.md |
@vigsterkr thanks! However, I'm not sure how to fix some of these errors. I ran the clang-format-3.8 as recommended by the script, but I still get errors like these |
@grig-guz i'm not so sure what you mean by the cropped image but this is clearly a formatting problem: or
should be |
The style check passed. Is it fine now? |
Also, the formatting error detection script was inconsistent in some places. Sometimes, it required for line padding to only consist of tabs, and in other classes it was asking for tabs and 2-3 spaces. |
Thx for the patch! |
Fixed the previous pull request