deletes everything we deprecated for #4074 #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
reviewed
Apr 3, 2018
| EXPECT_NEAR(result, -0.73170731707317049, 1E-15); | ||
| } | ||
|
|
||
| TEST(RationalApproximationIndividualJob, compute_cocg) |
There was a problem hiding this comment.
are these things covered by other tests? I mean the numerical results ... If not, we need to do that!
karlnapf
requested changes
Apr 3, 2018
There was a problem hiding this comment.
Great! Deleting 2k lines of totally unused code!
One thing: we need to make sure that we dont decrease test coverage. So we need to port all the unit tests to the refactored version of the log-det estimators to ensure we are still testing for those numerical results.
|
Yeah I am working on that.... I will make a separate pr :) |
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.