Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CMath trigonometric functions #4237

Merged
merged 1 commit into from Apr 9, 2018
Merged

Remove CMath trigonometric functions #4237

merged 1 commit into from Apr 9, 2018

Conversation

syashakash
Copy link
Contributor

@syashakash syashakash commented Apr 7, 2018 •
edited

Refer #4186
Removes

  • CMath::sin
  • CMath::asin
  • CMath::sinh
  • CMath::cos
  • CMath::cosh
  • CMath::acos
  • CMath::tan
  • CMath::tanh
  • CMath::atan2
  • CMath::atan

karlnapf
karlnapf approved these changes Apr 9, 2018
View reviewed changes
Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@karlnapf karlnapf merged commit eefcd07 into shogun-toolbox:develop Apr 9, 2018
@syashakash syashakash deleted the remove_trigonometric_functions branch April 11, 2018 17:58
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
@syashakash @ktiefe
Remove CMath trigonometric functions (shogun-toolbox#4237)
48aebc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlnapf karlnapf karlnapf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@syashakash @karlnapf