Feature/refactor meta #4257
Merged
Feature/refactor meta #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iglesias
commented
Apr 15, 2018
|
|
||
| #![extract_results] | ||
| RealVector d = hierarchical.get_merge_distances() | ||
| IntMatrix cp = hierarchical.get_cluster_pairs() |
There was a problem hiding this comment.
These ones had to go because the members are T*. These get_* methods wrap the T* into SGVector or SGMatrix.
iglesias
force-pushed
the
feature/refactor-meta
branch
from
97780b0
to
0ec09b3
Compare
iglesias
force-pushed
the
feature/refactor-meta
branch
from
de9eccf
to
4ae3866
Compare
karlnapf
reviewed
Apr 16, 2018
| watch_param("assignment_size", &assignment_size); | ||
| watch_param("assignment", &assignment, &table_size); | ||
| watch_param("table_size", &table_size); | ||
| watch_param("pairs", &pairs, &PAIRS_DIM_0, &merges); |
There was a problem hiding this comment.
ouch!!!
but I guess this works ...
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
* Add distance interface factory. Port Euclidean meta example to new API. * API port in hierarhical clustering meta-example. Add watch_params. * Port LARs meta example. * Minor name update revert. * Update data generated by meta examples. * Fix return type to base class in meta ex. Add base class to interfaces. * Disable Hierarchical clone test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.