remove RealFeatures from SWIG #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
force-pushed
the
feature/prune_features_from_swig
branch
3 times, most recently
from
d370a7a
to
d126293
Compare
|
The patch that really removes |
karlnapf
force-pushed
the
feature/prune_features_from_swig
branch
from
d126293
to
0cee3a1
Compare
karlnapf
force-pushed
the
feature/prune_features_from_swig
branch
from
0cee3a1
to
edfb688
Compare
|
Tada! |
iglesias
reviewed
Apr 19, 2018
| // definitely a matrix, might need to convert values | ||
| if (mat.num_rows>1 && mat.num_cols>1) | ||
| { | ||
| // TODO once needed |
|
It does, ends up in the last case on the bottom. But we could maybe better
put sg not implemented, you are right
On Thu, 19 Apr 2018 at 23:34, Fernando J. Iglesias García < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/interfaces/swig/shogun.i
<#4261 (comment)>
:
> }
+
+ // tag didnt match: either it was vector, or has different inner type
+
+ // definitely a matrix, might need to convert values
+ if (mat.num_rows>1 && mat.num_cols>1)
+ {
+ // TODO once needed
tmp failure with error?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4261 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqqvxg67QbfEWd79WOJMwXMlDkvZbeYks5tqRDngaJpZM4TYxtS>
.
--
Sent from my phone
|
karlnapf
commented
Apr 30, 2018
| MulticlassLabels labels_train(f_labels_train) | ||
| MulticlassLabels labels_test(f_labels_test) | ||
| #![create_features] | ||
|
|
||
| #![set_parameters] | ||
| real C = 1.0 | ||
| real epsilon = 0.0001 | ||
| GaussianKernel gauss_kernel(features_train, features_train, 15) |
There was a problem hiding this comment.
kernel bandwidth changed from 15 to 1, need to regenerated integration testing data
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.