Add additional check on LMNN user input. Closes #3975 #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add input check and assertion in LMNN regarding k used in KNN and the number of examples per class.
iglesias
force-pushed
the
bugfixing/3975
branch
from
d04e0ce
to
d0b7db4
Compare
|
Adding a default constructor to |
Trigger is build failure in MVS 14.0 at C:\...\include\algorithm(1502).
|
@lisitsyn , @vigsterkr, what do you think about RandomIterator's default constructor; any potential side-effect? Included because of https://ci.appveyor.com/project/vigsterkr/shogun/build/2335#L6154. |
iglesias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add input check and assertion in LMNN regarding k used in KNN and
the number of examples per class.