Feature/port mkl examples #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-add various default ctors -make CombinedKernel's has_property lazy evaluated and recursive -register parameters by base class -add binary_labels conversion to MKLClassification -update integration test data
karlnapf
force-pushed
the
feature/port_mkl_examples
branch
from
62d642f
to
f7bde3e
Compare
karlnapf
commented
May 2, 2018
| GaussianKernel gauss_kernel_1(2.0) | ||
| GaussianKernel gauss_kernel_2(3.0) | ||
| Kernel poly_kernel = kernel("PolyKernel", degree=2) | ||
| Kernel gauss_kernel_1 = kernel("GaussianKernel", log_width=0.0) |
There was a problem hiding this comment.
due to the changed gaussian kernel parameters, i needed to re-generate the integration testing data.
karlnapf
commented
May 2, 2018
| @@ -271,7 +271,7 @@ void CMKL::register_params() | |||
| rho = 0; | |||
| lp_initialized = false; | |||
|
|
|||
| SG_ADD((CSGObject**) &svm, "svm", "wrapper svm", MS_NOT_AVAILABLE); | |||
| SG_ADD((CMachine**)&svm, "svm", "wrapper svm", MS_NOT_AVAILABLE); | |||
There was a problem hiding this comment.
This is done as we want to register members by base type.
Here is an issue with this: users can now set any machine type to mkl.
This will lead to a runtime error, when the machine is used as an svm
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
-add various default ctors -make CombinedKernel's has_property lazy evaluated and recursive -register parameters by base class -add binary_labels conversion to MKLClassification -update integration test data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lambday @lisitsyn here is
addin action.