Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost functions now support Stan Math, Kept the previous classes for backward compatability. #4294

Closed
wants to merge 39 commits into from

Commits on Jun 2, 2018

  1. Configuration menu
    Copy the full SHA
    220b11d View commit details
    Browse the repository at this point in the history
  2. Built a class on stan that can define any arbitrary cost function wit…

    …hout explicitly calculating the gradient
    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    ff2dd1a View commit details
    Browse the repository at this point in the history
  3. Wrote two unit tests to the new class to demonstrate how to write a n…

    …ew cost function on stan
    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    3cbecec View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    110337f View commit details
    Browse the repository at this point in the history
  5. Clang format

    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    8829625 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7737c07 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    74dddef View commit details
    Browse the repository at this point in the history
  8. Added the required changes from iteration 2 on shogun-toolbox#4294, s…

    …everal changes to styling and getting rid of vanilla loops + code restructure
    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    1e8002c View commit details
    Browse the repository at this point in the history
  9. Changed unit tests so it works with the new style including a few typ…

    …e aliases, actual unit tests haven't changed
    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    afc5327 View commit details
    Browse the repository at this point in the history
  10. Changed file names from FirstOrderSAGCostFunctionInterface to StanFir…

    …stOrderSAGCostFunction
    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    bc16178 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9dd2d19 View commit details
    Browse the repository at this point in the history
  12. Got rid of setters for changing behavior of cost function and paramet…

    …ers, since they should be immutable
    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    34d8aaa View commit details
    Browse the repository at this point in the history
  13. Added safeguards in constructor of StanFirstOrderSAGCostFunction to m…

    …ake sure input is correct
    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    8d89e4a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1bc7318 View commit details
    Browse the repository at this point in the history
  15. Clang formatting

    FaroukY committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    a926972 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1c60921 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. Changed the interface of the Cost funtion so that it works fine with …

    …the Minimizers and updaters
    FaroukY committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    4e8947b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c29fb06 View commit details
    Browse the repository at this point in the history
  3. updated old unit tests to work with new updated interface of cost fun…

    …ction, no major changes here [ci skip]
    FaroukY committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    21a9b7f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b719131 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2018

  1. Configuration menu
    Copy the full SHA
    cdadb8d View commit details
    Browse the repository at this point in the history
  2. Changed the unittest to suit the changed Interface of the cost functi…

    …on, including removing pointers [ci skip]
    FaroukY committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    87a663e View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2018

  1. changed parent class of StanFirstOrderSAGCostFunction to FirstOrderSt…

    …ochasticCostFunction, and made get_gradient() thread safe. [ci skip]
    FaroukY committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    cf2e3f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2018

  1. Created a new class StanNeuralLayer which will be the base class for …

    …a neural network layer [ci skip]
    FaroukY committed Jun 17, 2018
    Configuration menu
    Copy the full SHA
    d79f878 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ef7f67 View commit details
    Browse the repository at this point in the history
  3. updated the API of StanNeuralLayer and got rid of gradient computatio…

    …n from logic of layer
    FaroukY committed Jun 17, 2018
    Configuration menu
    Copy the full SHA
    11f8c1b View commit details
    Browse the repository at this point in the history
  4. Wrote the class StanNeuralLinearLayer which is a linear layer in the …

    …neural network, the logistic/softmax/relu layers will inherit from it [ci skip]
    FaroukY committed Jun 17, 2018
    Configuration menu
    Copy the full SHA
    272144d View commit details
    Browse the repository at this point in the history
  5. fix bug in StanNeuralLinearLayer class where m_stan_activations wasn'…

    …t aliased instead of A
    FaroukY committed Jun 17, 2018
    Configuration menu
    Copy the full SHA
    91cfef9 View commit details
    Browse the repository at this point in the history
  6. Created a Logistic layer for the stan Neural network, the class is ca…

    …lled StanNeuralLogisticLayer and computes activations as required [ci skip]
    FaroukY committed Jun 17, 2018
    Configuration menu
    Copy the full SHA
    cd56095 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2018

  1. Configuration menu
    Copy the full SHA
    6592f3f View commit details
    Browse the repository at this point in the history
  2. Started creating the neural network class that uses the stan neural

    layers
    
    The class is composed of parameters, and is only responsible for forward
    propagation of the layers.
    
    The Network will be used to generate a StanMatrix of outputs, which will
    then be used with Minimizers and StanCostFunctions to minimize the
    neural network's parameters
    
    [ci skip]
    FaroukY committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    5ba8e0e View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2018

  1. Configuration menu
    Copy the full SHA
    955a289 View commit details
    Browse the repository at this point in the history
  2. Changed a typo in Stan and changed interface of compute_activations a…

    …nd initialize_parameters to pass indices of start and end indices of the stan vector of parameters
    FaroukY committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    11f6dbd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    88b2c3c View commit details
    Browse the repository at this point in the history
  4. Changed initialize parameters interface to remove regularization temp…

    …orairly and replace it with indices for stan vector
    FaroukY committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    42c626f View commit details
    Browse the repository at this point in the history
  5. [ci skip] refactorred some code in neural net, finished the implement…

    …ation, but there is still some syntax errors that are being fixed, once they are addressed, we can start the testing
    FaroukY committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    8ae7fac View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2018

  1. [ci skip] 1) Added set_batch_size and implemented it 2) Fixed all syn…

    …tax errors apart from compute_activations(input) which has been silenced for now, needs discussion before fixing; 3) Got rid of get_section() logic and replaced it with other logic that doesn't have to copy the vector; 4) Got rid of get_larger_activation logic since it wasn't needed ; 5) Fixed all signature errors of compute_activations(params, i, j, layers) and its specializations; 6) Got rid of some typos, still many typos that need addressing TODO
    FaroukY committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    3398d7d View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2018

  1. Configuration menu
    Copy the full SHA
    a1a5b41 View commit details
    Browse the repository at this point in the history
  2. [ci skip] various updates to interfaces, neural network module is now…

    … done, the next part is to test it to check implementation details
    FaroukY committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    aea5dfa View commit details
    Browse the repository at this point in the history