Drop jinja2 in trained model serialization tests #4307
Conversation
|
@micmn from appveyor: |
| SG_REF(train_labels) | ||
| } | ||
|
|
||
| bool serialize_machine( |
There was a problem hiding this comment.
shall we put this into a helper, this kind of stuff is used in multiple places in the tests
| return load_success && (delete_success == 0); | ||
| } | ||
|
|
||
| CDenseFeatures<float64_t> *train_feats, *test_feats; |
There was a problem hiding this comment.
could we template the features as well?
|
@micmn I need to extend this for pausing tests so i am happy to complete this for u :) |
|
@micmn thx for the patch. We will cherry pick your commit and move on from there if you dont mind? |
|
Yes, of course :) |
|
@micmn we have trouble fixing this error. Would you mind having a look? :) |
micmn
force-pushed
the
feature/drop-jinja
branch
2 times, most recently
from
1961292
to
7dac419
Compare
|
green light! hello Microsoft :o |
|
Nice! Thanks! |
It may need some cleanup but this should do it.
@karlnapf #3537