Drop old preprocessor and converter api#4339
Merged
vigsterkr merged 4 commits intoJul 10, 2018
Merged
Conversation
Member
|
This looks good, @vigsterkr ? |
vigsterkr
force-pushed
the
feature/transformers
branch
from
June 28, 2018 10:49
550639e to
af8af72
Compare
vinx13
force-pushed
the
cleanup/preproc_api
branch
from
June 28, 2018 10:55
7e64df8 to
8304e53
Compare
karlnapf
reviewed
Jun 29, 2018
karlnapf
left a comment
karlnapf
left a comment
Member
There was a problem hiding this comment.
This all looks very reasonable to me.
CI is not happy though
Member
Author
|
python build failed because log exceed maximum length |
Member
|
restarting ... |
Member
|
I'll leave it to @vigsterkr to merge this though |
vigsterkr
force-pushed
the
feature/transformers
branch
from
July 10, 2018 14:18
af8af72 to
77a9f85
Compare
vinx13
force-pushed
the
cleanup/preproc_api
branch
from
July 10, 2018 14:53
f5661b0 to
c93b4dc
Compare
vigsterkr
force-pushed
the
feature/transformers
branch
from
July 10, 2018 15:12
77a9f85 to
8711ea6
Compare
Member
|
i had to fix some errors in the feature branch... it should be good now, as soon as things gets green in CIs i'm merging this and then i merge the whole feature branch into develop |
vinx13
force-pushed
the
cleanup/preproc_api
branch
from
July 10, 2018 15:29
c93b4dc to
552951e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.