Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old preprocessor and converter api #4339

Merged

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Jun 16, 2018

No description provided.

@lisitsyn
Copy link
Member

@lisitsyn lisitsyn commented Jun 19, 2018

This looks good, @vigsterkr ?

@vigsterkr vigsterkr force-pushed the shogun-toolbox:feature/transformers branch from 550639e to af8af72 Jun 28, 2018
@vinx13 vinx13 force-pushed the vinx13:cleanup/preproc_api branch from 7e64df8 to 8304e53 Jun 28, 2018
Copy link
Member

@karlnapf karlnapf left a comment

This all looks very reasonable to me.

CI is not happy though

@vinx13
Copy link
Member Author

@vinx13 vinx13 commented Jun 29, 2018

python build failed because log exceed maximum length
appveyor failed because of timeout

@karlnapf
Copy link
Member

@karlnapf karlnapf commented Jun 29, 2018

restarting ...

@karlnapf
Copy link
Member

@karlnapf karlnapf commented Jun 29, 2018

I'll leave it to @vigsterkr to merge this though

@vigsterkr vigsterkr force-pushed the shogun-toolbox:feature/transformers branch from af8af72 to 77a9f85 Jul 10, 2018
@vinx13 vinx13 force-pushed the vinx13:cleanup/preproc_api branch from f5661b0 to c93b4dc Jul 10, 2018
@vigsterkr vigsterkr force-pushed the shogun-toolbox:feature/transformers branch from 77a9f85 to 8711ea6 Jul 10, 2018
@vigsterkr
Copy link
Member

@vigsterkr vigsterkr commented Jul 10, 2018

i had to fix some errors in the feature branch... it should be good now, as soon as things gets green in CIs i'm merging this and then i merge the whole feature branch into develop

@vinx13 vinx13 force-pushed the vinx13:cleanup/preproc_api branch from c93b4dc to 552951e Jul 10, 2018
@vigsterkr vigsterkr merged commit 9710962 into shogun-toolbox:feature/transformers Jul 10, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@samdbrice samdbrice added the Tag: GSoC label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants