Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old preprocessor and converter api #4339

Merged

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Jun 16, 2018

No description provided.

@lisitsyn
Copy link
Member

This looks good, @vigsterkr ?

Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks very reasonable to me.

CI is not happy though

@vinx13
Copy link
Member Author

vinx13 commented Jun 29, 2018

python build failed because log exceed maximum length
appveyor failed because of timeout

@karlnapf
Copy link
Member

restarting ...

@karlnapf
Copy link
Member

I'll leave it to @vigsterkr to merge this though

@vigsterkr
Copy link
Member

i had to fix some errors in the feature branch... it should be good now, as soon as things gets green in CIs i'm merging this and then i merge the whole feature branch into develop

@vigsterkr vigsterkr merged commit 9710962 into shogun-toolbox:feature/transformers Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants