New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diffusion maps cookbook and converter factory #4340
diffusion maps cookbook and converter factory #4340
Conversation
Diffusion Maps | ||
============================== | ||
|
||
Diffusion Maps is a non-linear dimensionality reduction method that uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe shorten the sentence slightly.
@@ -0,0 +1,37 @@ | |||
============================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls adjust to text
Could you add a data file for the new example? |
|
||
Diffusion Maps is a non-linear dimensionality reduction method that uses | ||
eigenfunctions of Markov matrices to construct coordinates called diffusion maps | ||
that can be used to generate efficient representations of complex geometric structures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a key equation that we could show here? You could shop around the web to see what other libraries use to describe this
@karlnapf Travis is failing.... any ideas ? :) |
1c2960f
to
1db5334
Compare
bae2cca
to
1e93c7f
Compare
Example | ||
------- | ||
|
||
we create CDenseFeatures (RealFeatures, here 64 bit float values). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capital W
|
||
.. sgexample:: diffusionmaps.sg:create_features | ||
|
||
We create the :sgclass:`CDiffusionMaps` instance, and set its parameters. The diffusion kernel :math: `k` must satisfy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We create "a".
Also pls start new sentences in new lines
We create the :sgclass:`CDiffusionMaps` instance, and set its parameters. The diffusion kernel :math: `k` must satisfy | ||
the following properties: | ||
|
||
1. :math: `k` is symmetric :math: `{\bf k}(x, y) = {\bf k}(y, x)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be said in the intro
|
||
.. sgexample:: diffusionmaps.sg:set_parameters | ||
|
||
Then we apply DiffusionMaps, which gives us the distance embeddings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "the"
Also, please spell it "diffusion maps"
LGTM. @vinx13 did you change any of the API here? Do we need to change anything for that? |
No idea why windows fails, restarted. |
Yes, we have new api in feature/transformers branch. Something like |
Ah ok that is a feature branch then. |
f07e583
to
0cae94f
Compare
#![create_features] | ||
|
||
#![set_parameters] | ||
Kernel k = kernel("GaussianKernel", cache_size=10, log_width=10.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove the cache size. Sorry didnt spot this earler
0cae94f
to
3997028
Compare
Very useful stuff, thanks! :) |
* diffusion maps cookbook and converter factory * data update
No description provided.