Remove nonsensical CLinearMachine::compute_bias #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
karlnapf
commented
Jul 20, 2018
karlnapf
commented
- add bias coputation to CLinearRidgeRegression
- activate bias in LibLinear and LibLinearRegression by default
- cleanups
karlnapf
force-pushed
the
feature/no_compute_bias
branch
from
1b3a8bd
to
4643b82
Compare
* add bias coputation to CLinearRidgeRegression * activate bias in LibLinear and LibLinearRegression by default * cleanups
karlnapf
force-pushed
the
feature/no_compute_bias
branch
24 times, most recently
from
49a111b
to
ab88ee7
Compare
karlnapf
force-pushed
the
feature/no_compute_bias
branch
from
ab88ee7
to
8862afd
Compare
iglesias
requested changes
Jul 21, 2018
| @@ -88,6 +88,10 @@ template<class ST> CFeatures* CDenseFeatures<ST>::duplicate() const | |||
| return new CDenseFeatures<ST>(*this); | |||
| } | |||
|
|
|||
| { | |||
| return result; | |||
| } | |||
There was a problem hiding this comment.
This must have slipped through.
| @@ -1,5 +1,6 @@ | |||
| #include <shogun/labels/DenseLabels.h> | |||
| #include <shogun/labels/RegressionLabels.h> | |||
| #include <shogun/mathematics/linalg/LinalgNamespace.h> | |||
There was a problem hiding this comment.
Not necessary or was implicit include?
iglesias
reviewed
Jul 22, 2018
| @@ -71,11 +71,14 @@ bool CLinearRidgeRegression::train_machine(CFeatures* data) | |||
| linalg::matrix_prod(feats_matrix, feats_matrix, kernel_matrix, false, true); | |||
| linalg::add_diag(kernel_matrix, tau_vector); | |||
|
|
|||
| auto labels = ((CRegressionLabels*)m_labels)->get_labels(); | |||
There was a problem hiding this comment.
Minor: fix indentation of this block to rest of the function?
There was a problem hiding this comment.
will do autoformat once this works, thx
|
@iglesias actually the bias in the previous version was still wrong, I double checked things. Now it should work. |
|
Travis times out, but all tests pass locally, merging |
|
@karlnapf all right. I did not check the implementation of the equations 8-D |
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
* add/correct bias computation to CLinearRidgeRegression * cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.