Full support for std::vectors in Any [WIP] #4392
Conversation
|
Ok I introduced a test that shows that vectors generally work. What does not work is combinatorial stuff like vectors of SGVectors. Will work on that next |
| { | ||
| std::string str("some string"); | ||
| std::vector<std::string> lhs{str}; | ||
| std::vector<std::string> rhs{str}; |
There was a problem hiding this comment.
sure, we can register and we can do equals, and what happens is that the == operator of std::vector is called. This one uses the == operator on all elements, https://en.cppreference.com/w/cpp/container/vector/operator_cmp
It will not work recursively, i.e. std::vector<SGVector> will also use the == operator of the elements, which in shogun is pointer equality and not .equals
There was a problem hiding this comment.
Yeah that's what I wrote above ;)
|
Could this work for any stl collection? |
| for (auto l = lhs.cbegin(), r = rhs.cbegin(); l != lhs.cend(); | ||
| ++l, ++r) | ||
| { | ||
| if (!compare(*l, *r)) |
|
Probably, but I am not sure we need it, map/unordered_map is especially tricky to handle. |
|
Discussed this quite a bit with @vigsterkr and we think that we do need vector, list, map, set (at least). But set list and vector would be a great start if map is hard |
| std::vector<CSGObject*> rhs{rhs_obj.get()}; | ||
| Any any_lhs = make_any(lhs); | ||
| Any any_rhs = make_any(rhs); | ||
| EXPECT_EQ(any_lhs, any_rhs); |
There was a problem hiding this comment.
wait, did we want == operator for Any? Maybe I forgot this .... ;)
I think we can merge and then I add a vector parameter to our big shogun class test
|
Soooo. what is the latest here? :) |
|
Yes go for it. Can be extended later on but then we at least have vector |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue is now being closed due to a lack of activity. Feel free to reopen it. |
No description provided.