merge #4415
Closed
merge #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored all the opeations tests. * Decreased tolerance for float type tests to work with `float32_t`, `float64_t` and `floatmax_t` * Changed tests where `int` types are required to work with both `int` and `float` * Did not add `complex128_t`, `bool` or `char` tests
I added the SE test whilst there is no fix for the typed test for this case (see my PR description)
* get_epsilon is called inside each test case to determine the tolerance * tested these values with my own machine * solver tests will have a lower threshold, as these seem to change quite a bit depending on machine and lapack/blas installations * if typed testing is rolled out for all unit tests should move this to its own header file
* solvers have a fixed threshold * also fixed indentation
|
I think we mentioned somewhere in the docs that we want to use rebase based pulling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.